Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add doc about adding new states to context #3170

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kasir-barati
Copy link
Contributor

@kasir-barati kasir-barati commented Dec 24, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Docs
  • Other... Please describe:

What is the current behavior?

Just add a bit of doc about how you can attach request/response, or other stuff to your context object.

Issue Number: #2143

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kasir-barati
Copy link
Contributor Author

Ready for code review.

Some off-topic comments:

  1. Can we switch to pnpm? Is that doable for this repo? (saves space, net, and more importantly time).
  2. Can we update README.md of this repo to something that tells people how to run and test it on their local machine? Right now it is just your normal README.md that you'll get when creating a new NestJS app with Nest CLI.

@kasir-barati
Copy link
Contributor Author

JFYI, this question and the linked issue led to this PR 🙂.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant