Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sentry recipe #3175

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

smeubank
Copy link

@smeubank smeubank commented Jan 8, 2025

Create a Sentry Recipe

referencing

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Feature
  • Docs

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Adding a new recipe for using Sentry in NestJS

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@smeubank smeubank marked this pull request as draft January 8, 2025 15:22
smeubank and others added 2 commits January 8, 2025 16:42
fix some snippets and text, stick with CJS, and link to Sentry to cover ESM related topics
content/recipes/sentry.md Outdated Show resolved Hide resolved
content/recipes/sentry.md Outdated Show resolved Hide resolved
@chargome
Copy link

chargome commented Jan 9, 2025

@smeubank we also need to add either @SentryExceptionCaptured() to the global exception filter or provide SentryGlobalFilter as a provider for APP_FILTER (the part that comes after adding the module in https://docs.sentry.io/platforms/javascript/guides/nestjs/#use)

smeubank and others added 3 commits January 9, 2025 21:33
Co-authored-by: Charly Gomez <charly.gomez@sentry.io>
ESM information is in Sentry docs, should someone need it.
@smeubank smeubank marked this pull request as ready for review January 9, 2025 20:59
@smeubank
Copy link
Author

smeubank commented Jan 9, 2025

hi @kamilmysliwiec 👋

I am working with SDKs at Sentry. We added a dedicated NestJS SDK last year, and it's been goin strong! 📈

Thought it would be nice to get recipe in on the NestJS docs. What do you think?

@kamilmysliwiec
Copy link
Member

I'll give it a review shortly. Thank you :)


```

Afterward, add the `SentryModule` as a root module to your main module:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mini-suggestion as "afterwards" seems more common

Suggested change
Afterward, add the `SentryModule` as a root module to your main module:
Afterwards, add the `SentryModule` as a root module to your main module:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants