-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(platform): add fastify-multipart support for fastify platform #6935
base: master
Are you sure you want to change the base?
feat(platform): add fastify-multipart support for fastify platform #6935
Conversation
add FileInterceptor, FilesInterceptor, AnyFilesInterceptor and FileFieldsInterceptor for platform-fastify closes nestjs#6894
Pull Request Test Coverage Report for Build a3454d6e-4d99-46cf-8ab9-60f563025985
💛 - Coveralls |
This would be awesome. Does this support the |
Yes, it does support |
Hi guys, is there anything new? What should we do to merge this feature? |
Waiting for this so long. We want to move to fastify, this is a blocker. We would be very happy if this is merged. |
@micalevisk Hi, I see you approved PR. Does this mean that PR will get merged with next release? |
Unfortunately, no. I'm not a member of Nestjs's core team. It just means that I liked the proposed solution and tested it myself. It doesn't mean there is no room for improvement, of course. I do this from time to time with old PRs that I think are good to merge. Just to ping the core team (in some sort) :) |
Any status update on this PR? |
You may interested: nest-fastify-multer, it works fine in my project. |
any progress on this? |
@kamilmysliwiec, any chances to include this PR in Nest v9.0.0 release? |
@kamilmysliwiec |
Love how there are 2 pull requests fixing this issue, however it is still not possible to implement this on the nestjs standards. |
Any new updates for this PR? It seems that a lot of people have been asking for this for a long time and it makes sense for better feature parity between the express and fastify platforms. |
Any updates? @kamilmysliwiec |
What's blocking the PR to be merged @kamilmysliwiec @jmcdo29? |
any update? |
add FileInterceptor, FilesInterceptor, AnyFilesInterceptor and
FileFieldsInterceptor for platform-fastify
closes #6894
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently file upload interceptor is an important feature that is missing in
@nestjs/platform-fastify
.Issue Number: N/A
What is the new behavior?
FileInterceptor(s)
Behave as platform-express.
MultipartWrapper
A
fastify-multipart
wrapper that is responsible to handle file streams and return theses streams result to interceptor.options
object addingfileFilter
:fileFilter
size
andoriginalname
to fileoptions.dest
is truthy:path
anddestination
to file objectreq.files()
object differently in each method:files()
andany()
return array of filesfileFields()
return object with array of filesfilterAsyncGenerator
An utils function that filters AsyncGenerator validating
options.fileFilter
callback conditions before the write iteration begins.Does this PR introduce a breaking change?
Other information
I hope this pull request help us find the best solution for platform-fastify file upload interceptor.