New profile: device-flasher.linux #6616
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CalyxOS CLI device flasher. Has to be run under certain exceptions but works fine regardless.
lucasmz-dev
commented
Jan 15, 2025
| include allow-bin-sh.inc | ||
|
|
||
| blacklist /opt | ||
| blacklist /srv |
There was a problem hiding this comment.
Added this only because of rusty-snake's kyst, works fine so might as well keep it?
I'm not entirely sure what /opt and /srv are for.
There was a problem hiding this comment.
Added this only because of rusty-snake's kyst, works fine so might as well
keep it?
Seems fine.
I'm not entirely sure what /opt and /srv are for.
/opt is sometimes used for putting the entire installation files of third-party
programs into (as with Program Files in Windows).
/srv is used by things like HTTP servers.
kmk3
requested changes
Jan 15, 2025
Comment on lines
+1
to
+18
| # Firejail profile for device-flasher.linux | ||
| # Description: CalyxOS' device flasher | ||
| # This file is overwritten after every install/update | ||
|
|
||
| # Usage: run firejail ./device-flasher.linux in the folder with it and your factory image. | ||
|
|
||
| # Warning! | ||
| # ADB does not work under this sandbox, this is not a problem however, it just means you need to | ||
| # reboot the device into bootloader mode first. To do this, hold Volume Down + Power until you get | ||
| # into a screen with an Android robot being repaired. You'll need OEM Unlocking beforehand. | ||
|
|
||
| # Fedora: you may need to manually install a third-party resource for udev rules, as Fedora ships broken ones on android-tools. | ||
|
|
||
| quiet | ||
| include device-flasher.linux.local | ||
| # Persistent local customizations | ||
| include globals.local | ||
| # Persistent global definitions |
There was a problem hiding this comment.
Suggested change
| # Firejail profile for device-flasher.linux | |
| # Description: CalyxOS' device flasher | |
| # This file is overwritten after every install/update | |
| # Usage: run firejail ./device-flasher.linux in the folder with it and your factory image. | |
| # Warning! | |
| # ADB does not work under this sandbox, this is not a problem however, it just means you need to | |
| # reboot the device into bootloader mode first. To do this, hold Volume Down + Power until you get | |
| # into a screen with an Android robot being repaired. You'll need OEM Unlocking beforehand. | |
| # Fedora: you may need to manually install a third-party resource for udev rules, as Fedora ships broken ones on android-tools. | |
| quiet | |
| include device-flasher.linux.local | |
| # Persistent local customizations | |
| include globals.local | |
| # Persistent global definitions | |
| # Firejail profile for device-flasher.linux | |
| # Description: CalyxOS' device flasher | |
| # This file is overwritten after every install/update | |
| quiet | |
| # Persistent local customizations | |
| include device-flasher.linux.local | |
| # Persistent global definitions | |
| include globals.local | |
| # Usage: Run firejail ./device-flasher.linux in the folder with it and your | |
| # factory image. | |
| # Warning: ADB does not work with this profile, so you need to reboot the | |
| # device into bootloader mode first. To do this, hold Volume Down + Power until | |
| # you get into a screen with an Android robot being repaired. You'll need OEM | |
| # Unlocking beforehand. | |
| # Fedora: You may need to manually install a third-party resource for udev | |
| # rules, as Fedora ships broken ones on android-tools. |
Sort/format/reword.
|
|
||
| ignore noexec ${HOME} | ||
|
|
||
| include allow-bin-sh.inc |
There was a problem hiding this comment.
Suggested change
| include allow-bin-sh.inc | |
| # Allow /bin/sh (blacklisted by disable-shell.inc) | |
| include allow-bin-sh.inc |
Comment on lines
+24
to
+27
| blacklist /opt | ||
| blacklist /srv | ||
| blacklist ${RUNUSER} | ||
| blacklist /usr/libexec |
There was a problem hiding this comment.
Suggested change
| blacklist /opt | |
| blacklist /srv | |
| blacklist ${RUNUSER} | |
| blacklist /usr/libexec | |
| blacklist ${RUNUSER} | |
| blacklist /opt | |
| blacklist /srv | |
| blacklist /usr/libexec |
Sort.
Comment on lines
+39
to
+43
| whitelist ${DOWNLOADS} | ||
| # The Downloads folder is the only folder available to the flasher, use it or manually whitelist another. | ||
| # Preferably use a sub-folder such as Downloads/CalyxOS/ to prevent issues. | ||
|
|
||
| include whitelist-run-common.inc |
There was a problem hiding this comment.
Suggested change
| whitelist ${DOWNLOADS} | |
| # The Downloads folder is the only folder available to the flasher, use it or manually whitelist another. | |
| # Preferably use a sub-folder such as Downloads/CalyxOS/ to prevent issues. | |
| include whitelist-run-common.inc | |
| whitelist ${DOWNLOADS} | |
| include whitelist-common.inc | |
| include whitelist-run-common.inc |
The comment is kind of redundant, as it generally applies to any profile with
whitelist ${DOWNLOADS} (or another XDG user directory).
Usually whitelist-common.inc is included when whitelist ${HOME}/... is used.
There was a problem hiding this comment.
I don't see much reason to use whitelist-common.inc, it isn't needed at all, especially being a CLI tool.
(I'll go ahead soon enough and apply the changes requested, I'd like to confirm flashing works, this is the only one I don't see why use whitelist-common in specific, removing the comments is fine)
Comment on lines
+47
to
+48
|
|
||
| include landlock-common.inc |
There was a problem hiding this comment.
Suggested change
| include landlock-common.inc |
Not currently used.
| disable-mnt | ||
| private-bin bash,cut,grep,ls,sed,sh,sleep,which | ||
| private-cache | ||
| private-etc alternatives,ca-certificates,crypto-policies,host.conf,hostname,hosts,ld.so.cache,ld.so.conf,ld.so.conf.d,ld.so.preload,locale,locale.alias,locale.conf,localtime,mime.types,nsswitch.conf,pki,protocols,resolv.conf,rpc,services,ssl,xdg |
There was a problem hiding this comment.
Suggested change
| private-etc alternatives,ca-certificates,crypto-policies,host.conf,hostname,hosts,ld.so.cache,ld.so.conf,ld.so.conf.d,ld.so.preload,locale,locale.alias,locale.conf,localtime,mime.types,nsswitch.conf,pki,protocols,resolv.conf,rpc,services,ssl,xdg | |
| private-etc @network,@tls-ca,host.conf,mime.types,rpc,services,xdg |
Use new private-etc groups (see #6400).
rusty-snake
reviewed
Jan 17, 2025
| private-etc alternatives,ca-certificates,crypto-policies,host.conf,hostname,hosts,ld.so.cache,ld.so.conf,ld.so.conf.d,ld.so.preload,locale,locale.alias,locale.conf,localtime,mime.types,nsswitch.conf,pki,protocols,resolv.conf,rpc,services,ssl,xdg | ||
| private-tmp | ||
|
|
||
| dbus-system none |
There was a problem hiding this comment.
Suggested change
| dbus-system none | |
| dbus-user none |
rusty-snake
reviewed
Jan 17, 2025
| private-tmp | ||
|
|
||
| dbus-system none | ||
| dbus-user none |
There was a problem hiding this comment.
Suggested change
| dbus-user none | |
| dbus-system none |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CalyxOS CLI device flasher. Has to be run under certain exceptions but works fine regardless.