Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up code #1130

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Clean up code #1130

merged 1 commit into from
Nov 18, 2024

Conversation

jkosternl
Copy link
Contributor

  • Simplify code, add final keyword, use diamond operator, correct English, use lambdas, remove .toString, use .isEmpty(), use .addAll, and more
  • Thanks to IntelliJ code analyses feature

* Simplify code, add final keyword, use diamond operator, correct English, use lambdas, remove .toString, use .isEmpty(), use .addAll, and more
* Thanks to IntelliJ code analyses feature
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 90.90909% with 9 lines in your changes missing coverage. Please review.

Project coverage is 78.14%. Comparing base (48ca3c2) to head (f1c64c9).
Report is 69 commits behind head on master.

Files with missing lines Patch % Lines
.../java/com/networknt/schema/utils/JsonNodeUtil.java 50.00% 1 Missing and 1 partial ⚠️
...java/com/networknt/schema/utils/StringChecker.java 0.00% 0 Missing and 2 partials ⚠️
src/main/java/com/networknt/schema/JsonSchema.java 85.71% 0 Missing and 1 partial ⚠️
...n/java/com/networknt/schema/JsonSchemaFactory.java 66.66% 1 Missing ⚠️
...ava/com/networknt/schema/PrefixItemsValidator.java 0.00% 0 Missing and 1 partial ⚠️
...om/networknt/schema/format/IriReferenceFormat.java 0.00% 0 Missing and 1 partial ⚠️
.../main/java/com/networknt/schema/utils/RFC5892.java 94.44% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1130      +/-   ##
============================================
- Coverage     78.90%   78.14%   -0.76%     
- Complexity     1965     2061      +96     
============================================
  Files           172      201      +29     
  Lines          6352     6850     +498     
  Branches       1255     1252       -3     
============================================
+ Hits           5012     5353     +341     
- Misses          867     1030     +163     
+ Partials        473      467       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@stevehu stevehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like 'sb.append(s, pos, close);' is a syntax for Java 9. We are using Java 11 to build but the output is still Java 8 binary now. Let's see if it works.

@stevehu stevehu merged commit 7c4944b into networknt:master Nov 18, 2024
4 checks passed
@stevehu
Copy link
Contributor

stevehu commented Nov 18, 2024

Java 8 can compile the code without any issues. Thanks.

@jkosternl jkosternl deleted the cleanup-prod-code branch November 19, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants