fix(cli): show deployment error message if any and stop process to av…

…oid infinite wait
netzo · Jun 4, 2024 · 7a8a38d · 7a8a38d
1 parent 43ad951
commit 7a8a38d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/lib/cli/src/subcommands/deploy.ts b/lib/cli/src/subcommands/deploy.ts
@@ -227,9 +227,7 @@ async function deploy(
     Deno.exit(1);
   }
 
-  const { data: deployments } = await api.deployments.get<
-    Paginated<Deployment>
-  >({
+  const { data: deployments } = await api.deployments.get<Paginated<Deployment>>({
     projectId: project.denoId,
   });
   if (!deployments) {
@@ -395,9 +393,10 @@ async function deploy(
       },
     );
 
-    const _denoDeployment = await api.deployments.post<Deployment>(data, {
+    const denoDeployment = await api.deployments.post<Deployment | { message: string }>(data, {
       projectId: project._id,
     });
+    if ("message" in denoDeployment) error(LOGS.deploymentError(denoDeployment.message));
   } catch (err: unknown) {
     if (err instanceof APIError) {
       if (deploySpinner) {

diff --git a/lib/plugins/netzolabs/islands/dialog-issues-create.tsx b/lib/plugins/netzolabs/islands/dialog-issues-create.tsx
@@ -102,7 +102,7 @@ export function DialogIssuesCreate(props: {
           options: [
             { value: "bug", label: "Reporte de error" },
             { value: "enhancement", label: "Solicitud de mejora" },
-            { value: "feature", label: "Solicitud de nueva función" },
+            { value: "feature", label: "Solicitud de nueva funcionalidad" },
             { value: "feedback", label: "Comentarios generales" },
             { value: "question", label: "Pregunta" },
           ],

diff --git a/lib/plugins/utils.ts b/lib/plugins/utils.ts
@@ -80,6 +80,9 @@ export const LOGS = {
   localEnvVarSet: (key: string) => {
     return `Overwrote remote environment variable "${key}" with local.`;
   },
+  deploymentError: (message: string) => {
+    return `DeploymentError: ${message}`;
+  },
 } as const;
 
 export const RESPONSES = {