Allow env=None
to load secrets from system environment
#21
+39
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for open-sourcing the package! I just gave it a spin and it looks promising. I found the use of dotenv a bit clumsy and implemented a workaround to use system environment variables. I thought I'd open a PR here in case someone else also finds it useful.
The new logic is as follows:
env is not None
, thenload_env_variables
will load the variables from pathenv
withdotenv.get_key
,env is None
, thenload_env_variables
will load the variables from system environment.Both cases will check that both environment variables exist.
Also, I was wondering: would it make sense to call these
ONSHAPE_{ACCESS,SECRET}_KEY
instead of just{ACCESS,SECRET}_KEY
?