-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Track v1.4] New PR branch to serve as submodule for scikit-tree #53
base: main
Are you sure you want to change the base?
Conversation
❌ Linting issuesThis PR is introducing linting issues. Here's a summary of the issues. Note that you can avoid having linting issues by enabling You can see the details of the linting issues under the
|
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot reproduce the error on my local machine with following code:
from sklearn.ensemble import RandomForestClassifier
import numpy as np
from inspect import signature
rnd = np.random.RandomState(0)
n_samples = 30
X = rnd.uniform(size=(n_samples, 3))
y = np.arange(n_samples)
clf_1 = RandomForestClassifier()
clf_1.set_params(random_state=0)
func = getattr(clf_1, "fit", None)
func(X,y)
args = [p.name for p in signature(func).parameters.values()]
func = getattr(clf_1, "score", None)
func(X,y)
args = [p.name for p in signature(func).parameters.values()]
func = getattr(clf_1, "partial_fit", None)
func(X,y)
args = [p.name for p in signature(func).parameters.values()]
The code should replicate most of the check_fit_score_takes_y
test, but it runs smoothly every time. I also don't understand why only these 2 CIs failed when all should have the same test library.
- Linux_Runs pylatest_conda_forge_mkl
- macOS pylatest_conda_mkl_no_openmp
If you try running the |
@adam2392 Is |
Yeah it should be. The test is commented out tho rn. |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All CIs passed.
62f0c60
to
ea330a7
Compare
TODO: Change
see: https://github.com/scikit-learn/scikit-learn/pull/27352/files and related PRs |
This was accomplished in 9a5d91b |
5ccd00f introduces a major change, where I.e. MultiviewSplitRecord could in principle override SplitRecord and store additional |
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
We should remove binning for now as it is a untested feature... |
…it-learn#29920) Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
…ant and keep_empty_features is False (scikit-learn#29950) Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
…kit-learn#30103) Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
…kit-learn#30083) Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Co-authored-by: Marc Torrellas Socastro <marc.torsoc@gmail.com> Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
…tor (scikit-learn#30171) Co-authored-by: Adam Li <adam2392@gmail.com>
…mes to contribution (scikit-learn#30177) Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
Co-authored-by: Lock file bot <noreply@github.com>
…30206) Co-authored-by: Lock file bot <noreply@github.com>
…30205) Co-authored-by: Lock file bot <noreply@github.com>
…#30204) Co-authored-by: Lock file bot <noreply@github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Co-authored-by: rajath.k <rajath.k@dish.com>
…t actually support NaN values (scikit-learn#25330) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai> Co-authored-by: adrinjalali <adrin.jalali@gmail.com>
Co-authored-by: Stefanie Senger <91849487+StefanieSenger@users.noreply.github.com> Co-authored-by: adrinjalali <adrin.jalali@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Reference Issues/PRs
As of v0.2 for sktree, we have decided we do not need a custom built and released via pypi scikit-learn fork. Instead, we just have to keep an updated fork branch here that maintains the changes under
tree/
andensemble/
.This branch has significantly lower diff and less complexity compared to e.g. #44
What does this implement/fix? Explain your changes.
Any other comments?