Skip to content

Commit

Permalink
Try removing tests
Browse files Browse the repository at this point in the history
Signed-off-by: Adam Li <adam2392@gmail.com>
  • Loading branch information
adam2392 committed Oct 17, 2023
1 parent 486e5a2 commit 030cb5d
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 15 deletions.
2 changes: 1 addition & 1 deletion sktree/_lib/sklearn_fork
Submodule sklearn_fork updated 33 files
+1 −1 benchmarks/bench_plot_nmf.py
+2 −2 benchmarks/bench_plot_polynomial_kernel_approximation.py
+4 −0 build_tools/cirrus/arm_tests.yml
+4 −1 doc/conf.py
+1 −1 doc/modules/grid_search.rst
+312 −228 doc/modules/linear_model.rst
+9 −3 doc/modules/model_evaluation.rst
+1 −0 doc/themes/scikit-learn-modern/layout.html
+13 −0 doc/themes/scikit-learn-modern/static/css/theme.css
+47 −0 doc/themes/scikit-learn-modern/static/js/details-permalink.js
+17 −0 doc/whats_new/v1.3.rst
+24 −0 doc/whats_new/v1.4.rst
+42 −15 examples/applications/plot_cyclical_feature_engineering.py
+1 −1 examples/linear_model/plot_poisson_regression_non_normal_loss.py
+1 −1 examples/linear_model/plot_tweedie_regression_insurance_claims.py
+2 −2 setup.py
+4 −3 sklearn/cluster/tests/test_hdbscan.py
+1 −1 sklearn/decomposition/_kernel_pca.py
+14 −1 sklearn/decomposition/tests/test_kernel_pca.py
+34 −0 sklearn/inspection/_plot/tests/test_boundary_decision_display.py
+12 −6 sklearn/metrics/_classification.py
+1 −1 sklearn/metrics/_regression.py
+165 −212 sklearn/metrics/_scorer.py
+27 −0 sklearn/metrics/tests/test_classification.py
+150 −49 sklearn/metrics/tests/test_score_objects.py
+5 −3 sklearn/tests/metadata_routing_common.py
+1 −1 sklearn/tree/_tree.pxd
+5 −3 sklearn/tree/_tree.pyx
+13 −0 sklearn/tree/tests/test_tree.py
+3 −0 sklearn/utils/_param_validation.py
+9 −4 sklearn/utils/_response.py
+3 −0 sklearn/utils/tests/test_param_validation.py
+28 −0 sklearn/utils/tests/test_response.py
2 changes: 1 addition & 1 deletion sktree/tests/test_honest_forest.py
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ def test_sklearn_compatible_estimator(estimator, check):
"check_class_weight_classifiers",
# TODO: this is an error. Somehow a segfault is raised when fit is called first and
# then partial_fit
"check_fit_score_takes_y",
# "check_fit_score_takes_y",
]:
pytest.skip()
check(estimator)
18 changes: 9 additions & 9 deletions sktree/tests/test_supervised_forest.py
Original file line number Diff line number Diff line change
Expand Up @@ -193,15 +193,15 @@ def _trunk(n, p=10, random_state=None):
)
def test_sklearn_compatible_estimator(estimator, check):
# TODO: remove when we can replicate the CI error...
if isinstance(
estimator,
(
ExtraObliqueRandomForestClassifier,
ObliqueRandomForestClassifier,
PatchObliqueRandomForestClassifier,
),
) and check.func.__name__ in ["check_fit_score_takes_y"]:
pytest.skip()
# if isinstance(
# estimator,
# (
# ExtraObliqueRandomForestClassifier,
# ObliqueRandomForestClassifier,
# PatchObliqueRandomForestClassifier,
# ),
# ) and check.func.__name__ in ["check_fit_score_takes_y"]:
# pytest.skip()
check(estimator)


Expand Down
8 changes: 4 additions & 4 deletions sktree/tree/tests/test_tree.py
Original file line number Diff line number Diff line change
Expand Up @@ -226,10 +226,10 @@ def test_pickle_splitters():
)
def test_sklearn_compatible_estimator(estimator, check):
# TODO: remove when we can replicate the CI error...
if isinstance(
estimator, (PatchObliqueDecisionTreeClassifier, ExtraObliqueDecisionTreeClassifier)
) and check.func.__name__ in ["check_fit_score_takes_y"]:
pytest.skip()
# if isinstance(
# estimator, (PatchObliqueDecisionTreeClassifier, ExtraObliqueDecisionTreeClassifier)
# ) and check.func.__name__ in ["check_fit_score_takes_y"]:
# pytest.skip()
check(estimator)


Expand Down

0 comments on commit 030cb5d

Please sign in to comment.