Fix

Signed-off-by: Adam Li <adam2392@gmail.com>
neurodata · Oct 10, 2024 · 212db75 · 212db75
1 parent 2bd01f9
commit 212db75
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/treeple/tests/test_honest_forest.py b/treeple/tests/test_honest_forest.py
@@ -313,6 +313,7 @@ def test_sklearn_compatible_estimator(estimator, check):
         # TODO: this is an error. Somehow a segfault is raised when fit is called first and
         # then partial_fit
         "check_fit_score_takes_y",
+        "check_do_not_raise_errors_in_init_or_set_params",
     ]:
         pytest.skip()
     check(estimator)

diff --git a/treeple/tree/tests/test_honest_tree.py b/treeple/tree/tests/test_honest_tree.py
@@ -171,7 +171,11 @@ def test_sklearn_compatible_estimator(estimator, check):
     # XXX: can include this "generalization" in the future if it's useful
     #  zero sample weight is not "really supported" in honest subsample trees since sample weight
     #  for fitting the tree's splits
-    if check.func.__name__ in ["check_class_weight_classifiers", "check_classifier_multioutput"]:
+    if check.func.__name__ in [
+        "check_class_weight_classifiers",
+        "check_classifier_multioutput",
+        "check_do_not_raise_errors_in_init_or_set_params",
+    ]:
         pytest.skip()
     check(estimator)