Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT Submoduletest #250

Closed
wants to merge 5 commits into from
Closed

MAINT Submoduletest #250

wants to merge 5 commits into from

Conversation

adam2392
Copy link
Collaborator

@adam2392 adam2392 commented Apr 2, 2024

Fixes #

Changes proposed in this pull request:

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

adam2392 added 5 commits April 2, 2024 13:05
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Copy link
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current fork uses a previous version of partial_fit, which uses update_node as a function in tree.pyx. I don't have guarantee on whether it is valid. Likely the cause of some of the segfaults.

I still don't see the reason of such a switch (up-to-date partial_fit with segfaults). If you can point me to the log of actual errors it would be appreciated.

@adam2392
Copy link
Collaborator Author

adam2392 commented Apr 9, 2024

Closed by #249

@adam2392 adam2392 closed this Apr 9, 2024
@adam2392 adam2392 deleted the submoduletest branch April 9, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants