FIX remove regressor multi_label tag #339
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam2392
approved these changes
Dec 17, 2024
treeple/tree/_classes.py
Outdated
| @@ -2441,7 +2441,7 @@ def __sklearn_tags__(self): | |||
| # XXX: nans should be supportable in SPORF by just using RF-like splits on missing values | |||
| # However, for MORF it is not supported | |||
| tags = super().__sklearn_tags__() | |||
| tags.regressor_tags.multi_label = True | |||
| # tags.regressor_tags.multi_label = True | |||
There was a problem hiding this comment.
Perhaps let's just add an inline comment saying "TODO: add regression support"?
adam2392
requested changes
Dec 17, 2024
adam2392
reviewed
Dec 23, 2024
| @@ -29,7 +29,7 @@ jobs: | |||
| matrix: | |||
| os: # see scipy wheels.yml GH actions | |||
| - [ubuntu-22.04, manylinux, x86_64] | |||
| - [macos-12, macosx, x86_64] | |||
| - [macos-latest, macosx, x86_64] | |||
There was a problem hiding this comment.
For my education, why do we need this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Any other comments?