Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt at fixing corruption when minmized #277

Closed
wants to merge 1 commit into from
Closed

Attempt at fixing corruption when minmized #277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions module/rdpClientCon.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1225,11 +1225,12 @@ rdpClientConProcessMsgClientSuppressOutput(rdpPtr dev, rdpClientCon *clientCon)
LLOGLN(10, ("rdpClientConProcessMsgClientSuppressOutput: "
"suppress %d left %d top %d right %d bottom %d",
suppress, left, top, right, bottom));
clientCon->suppress_output = suppress;
clientCon->suppress_output = suppress == 0 ? 0 : 1;
if (suppress == 0)
{
rdpClientConAddDirtyScreen(dev, clientCon, left, top,
right - left, bottom - top);
clientCon->suppress_output = 2;
}
return 0;
}
Expand Down Expand Up @@ -2631,11 +2632,16 @@ rdpDeferredUpdateCallback(OsTimerPtr timer, CARD32 now, pointer arg)
clientCon->updateScheduled = FALSE;
clientCon->lastUpdateTime = now;

if (clientCon->suppress_output)
if (clientCon->suppress_output == 1)
{
LLOGLN(10, ("rdpDeferredUpdateCallback: suppress_output set"));
return 0;
}
else if (clientCon->suppress_output == 2)
{
id.flags = KEY_FRAME_REQUESTED;
Copy link
Member

@metalefty metalefty Jan 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about some log like this here?

LLOGLN(0, ("rdpDeferredUpdateCallback: KEY_FRAME_REQUESTED"));

clientCon->suppress_output = 0;
}
if (clientCon->shmemstatus == SHM_UNINITIALIZED || clientCon->shmemstatus == SHM_RESIZING) {
LLOGLN(10, ("rdpDeferredUpdateCallback: clientCon->shmemstatus "
"is not valid for capture operations: %d"
Expand Down