Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add crd.rbac.enabled value to core helm chart #287

Closed
wants to merge 1 commit into from
Closed

fix: add crd.rbac.enabled value to core helm chart #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion charts/core/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,9 @@ Parameter | Description | Default | Notes
`bottlerocket.enabled` | Set to true if using AWS bottlerocket | `false` |
`bottlerocket.runtimePath` | If bottlerocket is enabled, this local containerd socket path will be used | `/run/dockershim.sock` |
`admissionwebhook.type` | admission webhook type | `ClusterIP` |
`crdwebhook.enabled` | Enable crd service and create crd related resources | `true` |
`crdwebhook.enabled` | Enable crd service and create crd related resources except for RBAC resources (see `crd.rbac.enabled`) | `true` |
`crdwebhook.type` | crd webhook type | `ClusterIP` |
`crd.rbac.enabled` | Enable crd RBAC resources (e.g. ClusterRoles, ClusterRolebindings) | `true` |
`awsbilling.enabled` | If true, install AWS billing csp adapter | `false` |
`awsbilling.accountNumber` | AWS Account Number | `nil` | Follow AWS subscription instruction
`awsbilling.roleName` | AWS Role name for billing | `nil` | Follow AWS subscription instruction
Expand Down
2 changes: 1 addition & 1 deletion charts/core/templates/crd-role-least.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if and .Values.crdwebhook.enabled .Values.leastPrivilege -}}
{{- if and .Values.crd.rbac.enabled .Values.leastPrivilege -}}
{{- $oc4 := and .Values.openshift (semverCompare ">=1.12-0" (substr 1 -1 .Capabilities.KubeVersion.GitVersion)) -}}
{{- $oc3 := and .Values.openshift (not $oc4) (semverCompare ">=1.9-0" (substr 1 -1 .Capabilities.KubeVersion.GitVersion)) -}}
# ClusterRole for NeuVector to operate CRD
Expand Down
2 changes: 1 addition & 1 deletion charts/core/templates/crd-role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if and .Values.crdwebhook.enabled (not .Values.leastPrivilege) -}}
{{- if and .Values.crd.rbac.enabled (not .Values.leastPrivilege) -}}
{{- $oc4 := and .Values.openshift (semverCompare ">=1.12-0" (substr 1 -1 .Capabilities.KubeVersion.GitVersion)) -}}
{{- $oc3 := and .Values.openshift (not $oc4) (semverCompare ">=1.9-0" (substr 1 -1 .Capabilities.KubeVersion.GitVersion)) -}}
# ClusterRole for NeuVector to operate CRD
Expand Down
4 changes: 4 additions & 0 deletions charts/core/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,6 +493,10 @@ crdwebhook:
enabled: true
type: ClusterIP

crd:
rbac:
enabled: true

awsbilling:
enabled: false
accountNumber: ""
Expand Down