Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make service_token optional and refactor to implement only in base class #40

Closed
wants to merge 1 commit into from
Closed

Make service_token optional and refactor to implement only in base class #40

wants to merge 1 commit into from

Conversation

clriesco
Copy link
Contributor

@clriesco clriesco commented Dec 5, 2024

Description

Make service_token optional and refactor to implement only in base class

Is this PR related with an open issue?

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

Funny gif

Put a link of a funny gif inside the parenthesis-->

aaitor
aaitor reviewed Dec 5, 2024
View reviewed changes
Copy link
Member

@aaitor aaitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably you can cache the service token when you generated in a map where the key is the did, so if it's not given you just need to generate the token once per payments instance

@clriesco clriesco closed this Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaitor aaitor aaitor left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clriesco @aaitor