Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcAppContent): don't remove list when showing details in mobile or no-split mode #6261

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wofferl
Copy link
Contributor

@wofferl wofferl commented Nov 23, 2024

☑️ Resolves

As mentioned in #6204 the change in 8.10.0 causes the item list to rebuild every time the details of an item are shown.
With a dynamic list like in the news app, where read items are removed from the list when refreshing it, this means that the selected item you looked at the details are gone immediately when you close the details.
It also affects the performance, because of the rebuilding when closing the details, which is notable on mobile devices.

I think there is no technical reason to delete it, so it is better to just hide the list.

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.52%. Comparing base (cc8130c) to head (c2832fa).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6261   +/-   ##
=======================================
  Coverage   42.52%   42.52%           
=======================================
  Files         156      156           
  Lines        4026     4026           
  Branches     1036     1036           
=======================================
  Hits         1712     1712           
  Misses       2198     2198           
  Partials      116      116           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…r no-split mode

Signed-off-by: Wolfgang <github@linux-dude.de>
@wofferl wofferl force-pushed the fix_appcontent_list branch from d82dbf3 to c2832fa Compare January 11, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NcAppContent] list is rebuild every time when details were shown with no-split or mobile view
3 participants