Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release v8.22.0 #6321

Merged
merged 1 commit into from
Dec 23, 2024
Merged

chore: release v8.22.0 #6321

merged 1 commit into from
Dec 23, 2024

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Dec 20, 2024

Changelog

v8.22.0 (2024-12-20)

Full Changelog

🚀 Enhancements

  • feat(NcAvatar): implement custom javascript hook action for the contacts menu #6238 (st3iny)
  • feat(NcAppNavigation): add n hotkey to toggle navigation #6311 (skjnldsv)

🐛 Fixed bugs

  • fix(NcAppNavigationItem): TypeError: this.$refs.actions.$refs.menuButton is undefined #6226 (wofferl)
  • fix(NcListItem): Don't require name prop by @artonge in #6128 (artonge)
  • style(NcCheckboxRadioSwitch): fix styles in disabled state #6265 (Antreesy)
  • fix(NcModal): make 'Close' button the last element for the focus-trap #6266 (Antreesy)
  • fix(NcAppNavigation): Fix sidebar position in RTL and mobile mode.#6260 (falghamdi125)
  • fix(NcAppContent): add RTL support #6303 (hamza221)
  • fix(NcCheckboxRadioSwitch): RTL support #6302 (hamza221)
  • fix(NcDateTimePicker): popup position #6312 (hamza221)
  • Fix(NcSettingsSection): Add RTL support to NcSettingsSection info icon. #6290 (falghamdi125)
  • Fix(NcDashboardWidgetItem): Add RTL support to NcDashboardWidgetItem #6292 (falghamdi125)
  • fix(useHotKey): allow hotkeys with implicit SHIFT and add caseSensitive, custom event filter options #6301 (Antreesy)
  • fix(NcRichContenteditable): prevent content from overflowing #6316 (Antreesy)
  • fix(NcActionButton): RTL support #6200 (falghamdi125)

Changed

  • docs(NcDateTimePickerNative): add time picker example #6188 (GVodyanov)
  • chore(NcAppSidebarTabs): remove internal component from docs #6253 (ShGKme)
  • Updated workflows and dependencies
  • Updated translations

New Contributors

@hamza221 hamza221 added the 3. to review Waiting for reviews label Dec 20, 2024
@hamza221 hamza221 requested a review from Antreesy December 20, 2024 13:10
@hamza221 hamza221 self-assigned this Dec 20, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@hamza221 hamza221 requested a review from Antreesy December 20, 2024 13:38
@hamza221 hamza221 marked this pull request as draft December 20, 2024 13:39
@hamza221 hamza221 marked this pull request as ready for review December 20, 2024 13:46
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Talk, doesn't seem to break anything. But I'm not sure about last-minute hotkey merge without translations, therefore leaving it for the next reviewer 🦭

@skjnldsv
Copy link
Contributor

Tested with Talk, doesn't seem to break anything. But I'm not sure about last-minute hotkey merge without translations, therefore leaving it for the next reviewer 🦭

Just as a quick note, if you check transifex, you will see a plethora of untranslated strings for many languages. Even popular ones 😉
e.g, Spanish have 12, Portuguese have 56, Korean have 132, Italian have 9....

I don't think we really ever gave such a focus for translations (maybe we should) in libraries.
We lack a translation freeze and proper processes for the matter here.

@hamza221 hamza221 merged commit 2a0b696 into master Dec 23, 2024
19 checks passed
@hamza221 hamza221 deleted the v8.22.0 branch December 23, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants