Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard widget for NC20 #614

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Dashboard widget for NC20 #614

merged 1 commit into from
Oct 1, 2020

Conversation

korelstar
Copy link
Member

@korelstar korelstar commented Sep 20, 2020

closes #587, see also nextcloud/server#20930

Empty content with notes
Empty content Widget
Darkmode (outdated!) Empty content Darkmode Darkmode (outdated!) Widget Darkmode

Everything fine? @nextcloud/designers @nextcloud/notes

@korelstar korelstar added the enhancement New feature or request label Sep 20, 2020
@korelstar korelstar added this to the 4.0.0 milestone Sep 20, 2020
@korelstar korelstar added the feature: dashboard Related to Nextcloud dashboard label Sep 20, 2020
@korelstar korelstar marked this pull request as ready for review September 20, 2020 15:53
@claell
Copy link

claell commented Sep 20, 2020

One thought: Does this look coherent with the other available widgets?

@korelstar
Copy link
Member Author

I'm using the Nextcloud vue components for dashboard (i.e. the DashboardWidgetItem), so I would say yes. But I don't have a complete overview over all other existing dashboard widgets, since not every app has released the dashboard yet and screenshots in respective PR's are often outdated. But that's why I'm asking for reviews, here! 😃

lib/AppInfo/Application.php Outdated Show resolved Hide resolved
css/global.scss Show resolved Hide resolved
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, awesome work @korelstar! :) Mostly small feedback inline.

Edit: If there is no note favorited (cause e.g. the person just doesn’t use the feature), I’m wondering if we should keep the space on the left open, or instead remove the indent to give more space to the notes?

src/components/Dashboard.vue Outdated Show resolved Hide resolved
src/components/Dashboard.vue Outdated Show resolved Hide resolved
src/components/Dashboard.vue Outdated Show resolved Hide resolved
@claell
Copy link

claell commented Sep 21, 2020

I'm using the Nextcloud vue components for dashboard (i.e. the DashboardWidgetItem), so I would say yes. But I don't have a complete overview over all other existing dashboard widgets, since not every app has released the dashboard yet and screenshots in respective PR's are often outdated. But that's why I'm asking for reviews, here! 😃

I was only looking at the screenshots in the description of nextcloud/server#20930. Those might be outdated, though.

@jancborchardt jancborchardt mentioned this pull request Sep 22, 2020
4 tasks
@korelstar korelstar force-pushed the dashboard branch 2 times, most recently from 8ecd86c to af63760 Compare September 26, 2020 18:40
@korelstar
Copy link
Member Author

korelstar commented Sep 26, 2020

Thanks for your review, everybody!

Now, I've implemented (see updated screenshots above):

@jancborchardt If there are no favorite notes, the widget looks like this:
Screenshot

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works perfectly, great work @korelstar! :)

@korelstar
Copy link
Member Author

@nickvergessen I think I've implemented your requests, so I'm merging this now, since I can't wait for the review anymore due to the pending release. Please give an info if there is something outstanding, I will fix this afterwards.

@korelstar korelstar merged commit 937c087 into master Oct 1, 2020
@korelstar korelstar deleted the dashboard branch October 1, 2020 19:19
@nickvergessen
Copy link
Member

Yeah sorry all fine, didn't know you are still waiting for me (also I have 200+ unread notifications atm :( )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature: dashboard Related to Nextcloud dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notes widget for new dashboard
5 participants