-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard widget for NC20 #614
Conversation
0d0e3f9
to
9faff62
Compare
One thought: Does this look coherent with the other available widgets? |
I'm using the Nextcloud vue components for dashboard (i.e. the DashboardWidgetItem), so I would say yes. But I don't have a complete overview over all other existing dashboard widgets, since not every app has released the dashboard yet and screenshots in respective PR's are often outdated. But that's why I'm asking for reviews, here! 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, awesome work @korelstar! :) Mostly small feedback inline.
Edit: If there is no note favorited (cause e.g. the person just doesn’t use the feature), I’m wondering if we should keep the space on the left open, or instead remove the indent to give more space to the notes?
I was only looking at the screenshots in the description of nextcloud/server#20930. Those might be outdated, though. |
8ecd86c
to
af63760
Compare
Thanks for your review, everybody! Now, I've implemented (see updated screenshots above):
@jancborchardt If there are no favorite notes, the widget looks like this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works perfectly, great work @korelstar! :)
@nickvergessen I think I've implemented your requests, so I'm merging this now, since I can't wait for the review anymore due to the pending release. Please give an info if there is something outstanding, I will fix this afterwards. |
Yeah sorry all fine, didn't know you are still waiting for me (also I have 200+ unread notifications atm :( ) |
closes #587, see also nextcloud/server#20930
Everything fine? @nextcloud/designers @nextcloud/notes