fix(logout): Fixed app crash when app token is revoked

Signed-off-by: Ivan Sein <ivan@nextcloud.com>
nextcloud · Jan 23, 2025 · 9e7dac5 · 9e7dac5
1 parent c707966
commit 9e7dac5
Showing 1 changed file with 14 additions and 3 deletions.
diff --git a/NextcloudTalk/NCSettingsController.m b/NextcloudTalk/NCSettingsController.m
@@ -188,9 +188,11 @@ - (void)tokenRevokedResponseReceived:(NSNotification *)notification
 {
     NSString *accountId = [notification.userInfo objectForKey:@"accountId"];
     [self logoutAccountWithAccountId:accountId withCompletionBlock:^(NSError *error) {
-        [[NCUserInterfaceController sharedInstance] presentConversationsList];
-        [[NCUserInterfaceController sharedInstance] presentLoggedOutInvalidCredentialsAlert];
-        [[NCConnectionController sharedInstance] checkAppState];
+        if (!error) {
+            [[NCUserInterfaceController sharedInstance] presentConversationsList];
+            [[NCUserInterfaceController sharedInstance] presentLoggedOutInvalidCredentialsAlert];
+            [[NCConnectionController sharedInstance] checkAppState];
+        }
     }];
 }
 
@@ -417,6 +419,15 @@ - (void)getUserProfileForAccountId:(NSString *)accountId withCompletionBlock:(Up
 - (void)logoutAccountWithAccountId:(NSString *)accountId withCompletionBlock:(LogoutCompletionBlock)block
 {
     TalkAccount *removingAccount = [[NCDatabaseManager sharedInstance] talkAccountForAccountId:accountId];
+
+    if (!removingAccount) {
+        if (block) {
+            NSError *error = [NSError errorWithDomain:NSCocoaErrorDomain code:0 userInfo:nil];
+            block(error);
+        }
+        return;
+    }
+
     if (removingAccount.deviceIdentifier) {
         [[NCAPIController sharedInstance] unsubscribeAccount:removingAccount fromNextcloudServerWithCompletionBlock:^(NSError *error) {
             if (!error) {