Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uploading files in rare cases #1457

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Conversation

SystemKeeper
Copy link
Collaborator

@SystemKeeper SystemKeeper commented Dec 15, 2023

Sometimes trying to read files with NSFileCoordinatorReadingForUploading fails with

Error Domain=NSOSStatusErrorDomain Code=-10810 "(null)" UserInfo={_LSLine=213, _LSFunction=normalizeError}

At the same time NSFileCoordinatorReadingWithoutChanges seems to work in these cases. So now we use NSFileCoordinatorReadingWithoutChanges as a fallback, in case NSFileCoordinatorReadingForUploading failed.

Best reviewed as https://github.com/nextcloud/talk-ios/pull/1457/files?diff=unified&w=1

Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper SystemKeeper requested a review from Ivansss December 15, 2023 16:07
@Ivansss Ivansss merged commit 60d8c40 into master Dec 21, 2023
7 checks passed
@Ivansss Ivansss deleted the fix-uploading-files-in-some-cases branch December 21, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants