Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run on draft PRs and don't fail fast #1486

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Run on draft PRs and don't fail fast #1486

merged 1 commit into from
Jan 16, 2024

Conversation

SystemKeeper
Copy link
Collaborator

  • I think we should also run on draft PRs. It does not make sense to manually move to "Ready-for-review" and then back to Draft just for the workflows to run (also this does not work without another push right now, because the type "ready_to_review" is not checked by default, see https://github.com/orgs/community/discussions/25722#discussioncomment-3248917)
  • "fail-fast" should be disabled. We currently run 4 test scenarios (23, 27, 28, main), when one of these scenarios fail, all others are cancelled as well. When there's a specific issue in only one of the scenarios, the others should still continue to run.

Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper SystemKeeper requested a review from Ivansss January 14, 2024 12:07
@Ivansss Ivansss merged commit ebe371d into master Jan 16, 2024
7 checks passed
@Ivansss Ivansss deleted the update-testworkflow branch January 16, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants