Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add background task for decreasing unread badge number #1489

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

Ivansss
Copy link
Member

@Ivansss Ivansss commented Jan 15, 2024

Attempt to fix following app crash:

Screenshot 2024-01-15 at 10 59 20

@Ivansss Ivansss requested a review from SystemKeeper January 15, 2024 10:11
@SystemKeeper
Copy link
Collaborator

I am wondering if we should add a background task to the calling function, removeNotificationsWithNotificationIds in this case?

Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@Ivansss Ivansss force-pushed the add-bg-task-for-decreasing-unread-badge-number branch from a159bab to 78529cd Compare January 24, 2024 17:05
@Ivansss
Copy link
Member Author

Ivansss commented Jan 24, 2024

I am wondering if we should add a background task to the calling function, removeNotificationsWithNotificationIds in this case?

moved :)

Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@Ivansss Ivansss merged commit 9a67702 into master Jan 25, 2024
7 checks passed
@Ivansss Ivansss deleted the add-bg-task-for-decreasing-unread-badge-number branch January 25, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants