-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support videos in media view #1844
Support videos in media view #1844
Conversation
fb169a9
to
128246b
Compare
128246b
to
25ebf7e
Compare
Very cool @DanielStandfest, thanks a lot for working on this 👍 Btw, we can add you to the Nextcloud org if you like? Then you can directly push here. We also have a developer chat where we can create a guest account for you, if you like. Just let me know :) |
Thank you @SystemKeeper. Appreciate it. |
ec8ce19
to
b1e5032
Compare
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Any news on this one? |
Hello @DanielStandfest , Thanks a lot for your PR :) Sorry for our late reply, @SystemKeeper and I did take a look to your PR last week but forgot to write a reply here. We noticed a few things that could be addressed before merging your PR:
|
f822950
to
f46f50b
Compare
Hi @Ivansss, thank you for your valuable feedback! Points 1 and 2 have now been implemented. Additionally, I noticed the issue with unsupported video formats when swiping through webm and mkv videos. I’ve adjusted the getPreviousFileMessage and getNextFileMessage methods to address this. Regarding point 3, I’d suggest handling it as a separate feature in a future update, and I recommend creating a dedicated issue to track it. Thanks again for your insights! |
01324eb
to
5067285
Compare
Closes nextcloud#1702 Signed-off-by: Daniel Standfest <daniel@standfest.io>
5067285
to
9104ac8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice @DanielStandfest ! Thanks for your contribution 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your PR @DanielStandfest :)
added support for videos (and playback) when swiping in media view.
Closes #1702
@SystemKeeper