Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only query "getPeersInCall" when using internal signaling #1951

Merged
merged 1 commit into from
Jan 24, 2025
Merged

fix: Only query "getPeersInCall" when using internal signaling #1951

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions NextcloudTalk/NCCallController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,14 +197,15 @@ - (void)joinCall
[NCUtils log:[NSString stringWithFormat:@"Did join call in NCCallController for token %@", self.room.token]];

[self.delegate callControllerDidJoinCall:self];
[self getPeersForCall];
[self startMonitoringMicrophoneAudioLevel];

if (self->_externalSignalingController) {
if ([self->_externalSignalingController hasMCU]) {
[self createPublisherPeerConnection];
}
} else {
// Only with internal signaling we need to query the API for peers in call
[self getPeersForCall];
[self->_signalingController startPullingSignalingMessages];
}

Expand Down Expand Up @@ -820,7 +821,7 @@ - (void)checkMicAudioLevel
}];
}

#pragma mark - Call participants
#pragma mark - Call participants (internal signaling)

- (void)getPeersForCall
{
Expand Down Expand Up @@ -1506,7 +1507,7 @@ - (void)processUsersInRoom:(NSArray *)users
// Calculate sessions that join the call
[newSessions removeObjectsInArray:oldSessions];

if (newSessions.count > 0) {
if (newSessions.count > 0 && !_externalSignalingController) {
[self getPeersForCall];
}

Expand Down
Loading