F/http #166
Open
F/http #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian <sebastian@wiuwiu.de>
Signed-off-by: Sebastian <sebastian@wiuwiu.de>
Signed-off-by: Sebastian <sebastian@wiuwiu.de>
Signed-off-by: Sebastian <sebastian@wiuwiu.de>
Signed-off-by: Sebastian <sebastian@wiuwiu.de>
Signed-off-by: Sebastian <sebastian@wiuwiu.de>
sebastiansterk
force-pushed
the
f/http
branch
from
5027631 to
a941132
Compare
Signed-off-by: Sebastian <sebastian@wiuwiu.de>
sebastiansterk
force-pushed
the
f/http
branch
from
5508538 to
3310be7
Compare
|
Can someone review this PR please? |
| if($this->hashAlgo !== false){ | ||
| $password = $this->hashPassword($password); | ||
| } | ||
| $ch = curl_init(); |
There was a problem hiding this comment.
why manual curl and not \OCP\Http\Client\IClientService? Raw curl won't work with Nextcloud's configured HTTP proxies and some other things by default.
There was a problem hiding this comment.
Do you have any example or documentation about how to use \OCP\Http\Client\IClientService? Thanks
There was a problem hiding this comment.
No docs unfortunately nextcloud/documentation#2196 but you can take https://github.com/nextcloud/mail/blob/e8c4120f691591949baf664fc50f7947b55f9582/lib/Service/Avatar/Downloader.php as reference.
|
I reviewed but forgot to submit. My bad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #104