Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementation of possibility to add multiple volumes #46

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

jagedn
Copy link
Collaborator

@jagedn jagedn commented Jun 21, 2024

This implementation introduces a new config volumes (plural) as a List of VolumeSpec closures

Tested against the validation folder:

 jobs {
        volume = { type "host" name "scratchdir" }

        volumes = [
            { type "host" name "scratchdir" path "/var/data1" },
            { type "host" name "scratchdir" path "/var/data2" }
        ]
    }
  • you can use volume , volumes or a mix of both
  • you can/need to specify the path in "secondary" volumes
  • you can specify which volume uses as workDir (so path is not required)

closes #45

closes #45

Signed-off-by: Jorge Aguilera <jorge@edn.es>
@jagedn jagedn requested review from abhi18av and jhaezebr June 21, 2024 07:28
Copy link
Collaborator

@matthdsm matthdsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Collaborator

@jhaezebr jhaezebr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can understand the code :)

@jagedn
Copy link
Collaborator Author

jagedn commented Jun 21, 2024

Looks good as far as I can understand the code :)

You can take a look to the examples in the validation folder, these are "real" configurations executed against a local nomad instance

https://github.com/nextflow-io/nf-nomad/pull/46/files#diff-ee3e4320a49d7523b0af681bbc50ede9992e4094046302a2682764cdf9b44624

Copy link
Member

@abhi18av abhi18av left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to merge - thanks @jagedn !

@abhi18av abhi18av merged commit fa034a0 into master Jun 21, 2024
2 checks passed
@abhi18av abhi18av deleted the multiple-volumes branch June 21, 2024 09:42
@jagedn jagedn restored the multiple-volumes branch July 2, 2024 14:32
@jagedn jagedn deleted the multiple-volumes branch July 2, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add possibility to add multiple volumes
4 participants