Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nomad config issues using environment variables #50

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

jagedn
Copy link
Collaborator

@jagedn jagedn commented Jul 2, 2024

last changes in NomadConfig using the environment NOMAD_ADDRESS introduce some bugs

this PR fix them

Signed-off-by: Jorge Aguilera <jorge@edn.es>
@jagedn jagedn requested a review from abhi18av July 2, 2024 10:35
@jagedn jagedn merged commit 1d3ae0c into master Jul 2, 2024
2 checks passed
@jagedn jagedn deleted the fix-nomad-dc branch July 2, 2024 10:37
@abhi18av
Copy link
Member

abhi18av commented Jul 2, 2024

Thanks @jagedn !

I added some ideas regarding the gradle build process here #51

Please let me know your thoughts :)

@jagedn jagedn restored the fix-nomad-dc branch July 2, 2024 14:32
@jagedn jagedn deleted the fix-nomad-dc branch July 2, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants