Constraints refactor to introduce a specific models package #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok, (so, do I need to cancel my PR and we continue into yours right?) |
|
@jagedn , no you can just merge into your branch and then delete this :) We'll continue working on your branch and merge it finally to |
|
ahhh true, your PR is against my branch |
jagedn
pushed a commit
that referenced
this pull request
Jul 15, 2024
* refactor the package organization to create a separate package for models * Refactor the test folder and add license headers
abhi18av
added a commit
that referenced
this pull request
Jul 15, 2024
* implement ConstraintNodeSpec Signed-off-by: Jorge Aguilera <jorge@edn.es> * implement ConstraintAttrSpec Signed-off-by: Jorge Aguilera <jorge@edn.es> * Constraints refactor to introduce a specific models package (#68) * refactor the package organization to create a separate package for models * Refactor the test folder and add license headers * move contraintsbuilder to model Signed-off-by: Jorge Aguilera <jorge@edn.es> * refactor and new "raw" dsl to include open constraints Signed-off-by: Jorge Aguilera <jorge@edn.es> * iterate upon the constraint config [ci skip] * fix nomadlab typos Signed-off-by: Jorge Aguilera <jorge@edn.es> * use cloud cache in sun-nomadlab [ci skip] --------- Signed-off-by: Jorge Aguilera <jorge@edn.es> Co-authored-by: Abhinav Sharma <abhi18av@users.noreply.github.com> Co-authored-by: Abhinav Sharma <abhi18av@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jagedn 👋
While testing the #66 PR, I realized that we are using the
Specnames quite often within the main source code, however as per Groovy best practices, maybe we should reserve that name only fortests.With that in mind, I have refactored your PR to introduce a
nextflow.nomad.modelsto accommodate all the utility classes which we need to model the configuration layer for the plugin.Please let me know what do you think about the new structure overall?