Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move modules for cross-org tests to this repository #1

Merged
merged 5 commits into from
Nov 27, 2024

Conversation

jvfe
Copy link
Member

@jvfe jvfe commented Oct 2, 2024

Moves all modules and subworkflows used for testing in the old test-subworkflow-remote repo to this repository, along with a schema file that should enable the feature being implemented.

Copy link

@muffato muffato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, here is what we discussed earlier today:

  • Briefly expand the README to explain the purpose of the repo.
  • Only keep the files that are needed for the tests and to demonstrate the feature.

@jvfe jvfe marked this pull request as ready for review October 8, 2024 17:53
Copy link
Contributor

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will have to add a .nf-core.yml file with the following information:

repository_type: modules
org_path: nf-core-test

Otherwise LGTM :)

@jvfe jvfe requested a review from mirpedrol November 25, 2024 12:49
Copy link
Contributor

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@jvfe
Copy link
Member Author

jvfe commented Nov 27, 2024

Thanks for the review, Júlia! I don't have write access to the repository though, so I can't merge this PR.

@mirpedrol mirpedrol merged commit 4e7195f into nf-core-test:main Nov 27, 2024
@mirpedrol
Copy link
Contributor

Merged 😄 I also changed the permissions so you can merge in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants