Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving pplacement #826

Open
wants to merge 28 commits into
base: dev
Choose a base branch
from

Conversation

danilodileo
Copy link
Contributor

@danilodileo danilodileo commented Jan 21, 2025

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/ampliseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

The pull request Implements phylogenetic placement in alternative reference phylogenies based on HMM profile scoring.

@nf-core-bot
Copy link
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.0.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@erikrikarddaniel
Copy link
Member

erikrikarddaniel commented Jan 21, 2025

@danilodileo, there must be something wrong here. There are 280 changed files! Was your branch not up to date with dev here?

@danilodileo danilodileo changed the title Improving pplacement dev Improving pplacement Jan 22, 2025
@d4straub
Copy link
Collaborator

On the first glance there seem two problems. (1) nf-test output files are included but shouldnt. (2) Something with pulling upstream seems to have gone wrong, because .nf-core.yml attempts to revert to 2.12.0dev.

@danilodileo
Copy link
Contributor Author

On the first glance there seem two problems. (1) nf-test output files are included but shouldnt. (2) Something with pulling upstream seems to have gone wrong, because .nf-core.yml attempts to revert to 2.12.0dev.

Hi, yes, this was an old PR and even though I updated the branch something went wrong. I am working to fix it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants