Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added citations to utils_nfcore_detaxizer_pipeline/main.nf #18

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

jannikseidelQBiC
Copy link
Collaborator

@jannikseidelQBiC jannikseidelQBiC commented Mar 5, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).

Added citations to the subworkflow utils_nfcore_detaxizer_pipeline/main.nf

  • To finish nf-core TODOs the citations of used tools was included in the above mentioned subworkflow
  • Linting is failing at the moment because schemastore.org is down

Copy link
Contributor

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

"Kraken2 (Wood et al. 2019),",
!params["skip_blastn"] ? "BLAST (Altschul et al. 1990)," : "",
!params["skip_blastn"] | params["enable_filter"] ? "seqkit (Shen et al. 2016)," : "",
"fastp (Chen et al. 2018)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could roughly keep the sequence of the tools, i.e. to put fastp right after FastQC or such.

@jannikseidelQBiC jannikseidelQBiC merged commit d4ef442 into nf-core:dev Mar 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants