Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections release 1.1.0 I #47

Merged

Conversation

jannikseidelQBiC
Copy link
Collaborator

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/detaxizer branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Changes requested by reviewers for release 1.1.0 were addressed

@jannikseidelQBiC
Copy link
Collaborator Author

@nf-core-bot fix linting

Copy link
Contributor

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot judge whether that are all changes that James suggested, but the changes seem fine to me

@jannikseidelQBiC
Copy link
Collaborator Author

There are some requested changes I decided to open an issue for them after the release. These are enhanchements that do not change the functionality of detaxizer.

@jannikseidelQBiC jannikseidelQBiC merged commit 51ba34e into nf-core:dev Nov 4, 2024
10 checks passed
@jannikseidelQBiC jannikseidelQBiC deleted the corrections_release1.1.0_I branch November 4, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants