Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD tabix index for indexcov #6121

Merged
merged 6 commits into from
Aug 22, 2024
Merged

Conversation

lindenb
Copy link
Contributor

@lindenb lindenb commented Aug 6, 2024

bed.gz produced by indexcov is bgzipped but is missing an index.

This pr invokes tabix and creates a TBI index for the bed.gz file

There is a new output: bed_index

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • [ X Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@lindenb
Copy link
Contributor Author

lindenb commented Aug 7, 2024

As far as I understand... It looks like the github validation is only failing when conda is used (?) .. and the checksum is not the same ??
how can I fix/bypass this ??

@SPPearce
Copy link
Contributor

As far as I understand... It looks like the github validation is only failing when conda is used (?) .. and the checksum is not the same ?? how can I fix/bypass this ??

Sorry, didn't notice this PR, it is generally faster to get a response by posting in the nf-core slack.
I have updated the tests to separately snapshot each channel, except the tbi channel only looks for the name.
There is a slightly outdated page with different assertions here.

@lindenb
Copy link
Contributor Author

lindenb commented Aug 22, 2024

@SPPearce thank you !

it is generally faster to get a response by posting in the nf-core slack.

yes, there was a thread on slack about this a few days ago but the burden for such a small change was just too demoralizing for me. https://nfcore.slack.com/archives/CE6SDBX2A/p1723041218939289

thank you again

@lindenb lindenb enabled auto-merge August 22, 2024 08:25
@lindenb lindenb added this pull request to the merge queue Aug 22, 2024
Merged via the queue into nf-core:master with commit 1667117 Aug 22, 2024
12 checks passed
@lindenb lindenb deleted the pl_indexcov_tabix branch August 22, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants