Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate vcf2db to wave #7022

Merged
merged 1 commit into from
Nov 19, 2024
Merged

migrate vcf2db to wave #7022

merged 1 commit into from
Nov 19, 2024

Conversation

matthdsm
Copy link
Contributor

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@matthdsm matthdsm requested a review from nvnieuwk November 19, 2024 07:44
@matthdsm matthdsm enabled auto-merge November 19, 2024 07:55
@matthdsm
Copy link
Contributor Author

Thanks @sateeshperi

@nvnieuwk nvnieuwk disabled auto-merge November 19, 2024 08:01
@nvnieuwk nvnieuwk merged commit 2a1ee18 into nf-core:master Nov 19, 2024
26 checks passed
@matthdsm matthdsm deleted the fix/vcf2db branch December 13, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants