Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mmseqs modules to v16 #7319

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Conversation

jasmezz
Copy link
Contributor

@jasmezz jasmezz commented Jan 16, 2025

Update remaining mmseqs modules to version 16 + update snapshots

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@jfy133
Copy link
Member

jfy133 commented Jan 17, 2025

We have the same database downloading issue as in the previous PR #7211

So force merging as otherwise no changes to files themselves

@jfy133 jfy133 merged commit 0306f1e into nf-core:master Jan 17, 2025
27 of 34 checks passed
@jasmezz jasmezz deleted the update-mmseqs-taxonomy branch January 17, 2025 12:18
@jasmezz
Copy link
Contributor Author

jasmezz commented Jan 17, 2025

In this case it's not the database download issue, but a different error only happening with version 16 of mmseqs/taxonomy. I wonder if we have to adjust some parameters in the module like with the --compressed flag here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants