Skip to content

Commit

Permalink
drop None values when checking for test names
Browse files Browse the repository at this point in the history
  • Loading branch information
mashehu committed Oct 22, 2024
1 parent 9bf91f5 commit 61bb733
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion nf_core/pipelines/lint/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ def _load_lint_config(self) -> bool:
# Check if we have any keys that don't match lint test names
if self.lint_config is not None:
for k, v in self.lint_config:
if k != "nfcore_components" and k not in self.lint_tests:
if v is not None and k != "nfcore_components" and k not in self.lint_tests:
# nfcore_components is an exception to allow custom pipelines without nf-core components
log.warning(f"Found unrecognised test name '{k}' in pipeline lint config")
is_correct = False
Expand Down
3 changes: 1 addition & 2 deletions tests/pipelines/lint/test_files_exist.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ def test_files_exist_missing_main(self):
def test_files_exist_deprecated_file(self):
"""Check whether deprecated file issues warning"""

nf = Path(self.new_pipeline, "parameters.settings.json")
nf.touch()
Path(self.new_pipeline, "parameters.settings.json").touch()

assert self.lint_obj._load()

Expand Down

0 comments on commit 61bb733

Please sign in to comment.