Skip to content

Commit

Permalink
Merge pull request #2956 from mashehu/less-strict-logo-compare
Browse files Browse the repository at this point in the history
Less strict logo comparison
  • Loading branch information
mashehu authored May 7, 2024
2 parents fc78f07 + 7067afe commit dda0b91
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
4 changes: 2 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
- Only match assignments of params in `main.nf` and not references like `params.aligner == <something>` ([#2833](https://github.com/nf-core/tools/pull/2833))
- Include test for presence of versions in snapshot ([#2888](https://github.com/nf-core/tools/pull/2888))
- Components: set correct sha before running component lint tests ([#2952](https://github.com/nf-core/tools/pull/2952))
- Less strict logo comparison ([#2956](https://github.com/nf-core/tools/pull/2956))

### Download

Expand All @@ -49,7 +50,7 @@
- Strip out mention of "Nextflow Tower" and replace with "Seqera Platform" wherever possible
- Fix issue with config resolution that was causing nested configs to behave unexpectedly ([#2862](https://github.com/nf-core/tools/pull/2862))
- Fix schema docs console output truncating ([#2880](https://github.com/nf-core/tools/pull/2880))
- fix: ensure path object converted to string before stripping quotes ([#2878](https://github.com/nf-core/tools/pull/2878))
- Ensure path object converted to string before stripping quotes ([#2878](https://github.com/nf-core/tools/pull/2878))
- Fix incorrect assertions for called_with on mocks ([#2891](https://github.com/nf-core/tools/pull/2891))
- Make cli-provided module/subworkflow names case insensitive ([#2869](https://github.com/nf-core/tools/pull/2869))
- Get immediate parent path name for schema creation ([#2886](https://github.com/nf-core/tools/pull/2886))
Expand All @@ -60,7 +61,6 @@
- fix(collectfile): sort true for methods_description_mqc.yaml ([#2947](https://github.com/nf-core/tools/pull/2947))
- chore(deps): update pre-commit hook astral-sh/ruff-pre-commit to v0.4.3 ([#2951](https://github.com/nf-core/tools/pull/2951))
- Restructure CHANGELOG.md ([#2954](https://github.com/nf-core/tools/pull/2954))
- Remove-premature-mention-nftest ([#2955](https://github.com/nf-core/tools/pull/2955))

## [v2.13.1 - Tin Puppy Patch](https://github.com/nf-core/tools/releases/tag/2.13) - [2024-02-29]

Expand Down
6 changes: 2 additions & 4 deletions nf_core/lint/files_unchanged.py
Original file line number Diff line number Diff line change
Expand Up @@ -160,10 +160,8 @@ def _tf(file_path: Union[str, Path]) -> Path:
if filecmp.cmp(_pf(f), _tf(f), shallow=True):
passed.append(f"`{f}` matches the template")
else:
if (
f.name.endswith(".png")
and os.stat(_pf(f)).st_mode == os.stat(_tf(f)).st_mode
and int(os.stat(_pf(f)).st_size / 100) == int(os.stat(_tf(f)).st_size / 100)
if f.name.endswith(".png") and int(os.stat(_pf(f)).st_size / 500) == int(
os.stat(_tf(f)).st_size / 500
):
# almost the same file, good enough for the logo
log.debug(f"Files are almost the same. Will pass: {f}")
Expand Down

0 comments on commit dda0b91

Please sign in to comment.