Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python linting template #2883

Merged
merged 7 commits into from
Mar 30, 2024
Merged

Conversation

ewels
Copy link
Member

@ewels ewels commented Mar 19, 2024

I don't think that we need the pyproject.toml file any more. This just has the Ruff linting config, but since we dropped check_samplesheet.py from the template I don't think that we really need Python linting any more?

It'd be nice to clean the repo root from as many dotfiles as possible, to keep things as simple as we can.

I couldn't find any other code around Python linting, so maybe the pre-commit python linting etc has already been removed.

@ewels ewels requested review from mashehu and mirpedrol March 19, 2024 13:33

This comment was marked as resolved.

@ewels ewels changed the base branch from master to dev March 19, 2024 13:59
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we could keep ruff to lint other scripts that pipelines add to the bin directory, do we want that? or is it ok to not lint custom python code on pipelines?

@ewels
Copy link
Member Author

ewels commented Mar 20, 2024

I was thinking that people could add ruff if they want to, just it seems a bit random to have it in the template when most pipelines have no Python scripts..

Should perhaps not have it in the linting test to fail if the pyproject file is there though in that case 🤔

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should perhaps not have it in the linting test to fail if the pyproject file is there though in that case

Sounds good! I will remove pyproject.toml from files that must not exist and merge this PR

nf_core/lint/files_exist.py Outdated Show resolved Hide resolved
nf_core/lint/files_exist.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.91%. Comparing base (0b1dcf2) to head (bbe232d).
Report is 2 commits behind head on dev.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ewels
Copy link
Member Author

ewels commented Mar 30, 2024

Thanks @mirpedrol !

@ewels ewels merged commit fae6770 into nf-core:dev Mar 30, 2024
35 checks passed
@ewels ewels deleted the remove-python-linting-template branch March 30, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants