-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove python linting template #2883
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but we could keep ruff to lint other scripts that pipelines add to the bin directory, do we want that? or is it ok to not lint custom python code on pipelines?
I was thinking that people could add ruff if they want to, just it seems a bit random to have it in the template when most pipelines have no Python scripts.. Should perhaps not have it in the linting test to fail if the pyproject file is there though in that case 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should perhaps not have it in the linting test to fail if the pyproject file is there though in that case
Sounds good! I will remove pyproject.toml
from files that must not exist and merge this PR
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files☔ View full report in Codecov by Sentry. |
Thanks @mirpedrol ! |
I don't think that we need the
pyproject.toml
file any more. This just has the Ruff linting config, but since we droppedcheck_samplesheet.py
from the template I don't think that we really need Python linting any more?It'd be nice to clean the repo root from as many dotfiles as possible, to keep things as simple as we can.
I couldn't find any other code around Python linting, so maybe the pre-commit python linting etc has already been removed.