Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev -> main for 3.1.0 #3336

Merged
merged 35 commits into from
Dec 12, 2024
Merged

dev -> main for 3.1.0 #3336

merged 35 commits into from
Dec 12, 2024

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Dec 10, 2024

No description provided.

@mashehu mashehu requested a review from mirpedrol December 10, 2024 11:49
@codecov Codecov
Copy link

codecov bot commented Dec 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.08%. Comparing base (05e7b95) to head (3c20e00).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
nf_core/pipelines/create/create.py 0.00% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mirpedrol
mirpedrol approved these changes Dec 10, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
mashehu and others added 17 commits December 10, 2024 15:15
@mashehu
change working dir when setting defaultBranch
15b044d
@mashehu
fix Changelog
1a22106
@mashehu
Be more verbose in approval check action
0b7fe50
@mashehu
fix if clause
f7ced6b
@mashehu
update changelog
1748613
@mashehu
add verbose mode to sync action
fa4e074
@mashehu
update changelog
5c8937e
@mirpedrol
Apply suggestions from code review
bb3a252
@mirpedrol
add input debug for workflow_dispatch sync action
379bad0
@mirpedrol
Merge pull request #3339 from mashehu/add-verbose-mode-to-sync
06db03f 
Add verbose mode to sync action
@mirpedrol
go back to original directory after configuring git defaultBranch
6148983
@mirpedrol
Merge pull request #3342 from mirpedrol/sync-default-branch
a4965f3 
go back to original directory after configuring git defaultBranch [no changelog]
@mirpedrol
add more debugging on sync GHA
df5b323
@mirpedrol
Merge pull request #3345 from mirpedrol/sync-default-branch
e8b6a9f 
add more debugging on sync GHA [no changelog]
@mirpedrol
echo message to sync GHA
1de1034
@mirpedrol
try exiting pipeline directory before saving defaultBranch
3858e38
@mirpedrol
cleanup debugging echo
380be6c
mirpedrol
mirpedrol approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having a second look after the updates, still LGTM 😄

@mashehu mashehu enabled auto-merge (squash) December 12, 2024 10:30
@mashehu mashehu merged commit 8232947 into main Dec 12, 2024
175 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirpedrol mirpedrol mirpedrol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mashehu @mirpedrol