Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modules: fix bump-versions: only append module name if it is a dir and contains main.nf #3384

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Modules: fix bump-versions: only append module name if it is a dir and contains main.nf #3384

merged 3 commits into from
Jan 7, 2025

Conversation

mirpedrol
Copy link
Member

Close #3382

@mirpedrol mirpedrol force-pushed the modules-bump-versions branch from 1454fb8 to 983dced Compare January 7, 2025 14:08
mashehu
mashehu approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you have time, a quick test would be great 🙂

mashehu
mashehu approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@mirpedrol mirpedrol merged commit 53703f4 into nf-core:dev Jan 7, 2025
88 checks passed
@mirpedrol mirpedrol deleted the modules-bump-versions branch January 7, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashehu mashehu mashehu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mirpedrol @mashehu