fix(pipeline-sync): Removes requirement to have authors defined #3393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If authors were missing the pipelines sync failed with a meaningless error. This wastes developer time while users have to fight configuration. Since authors are easy to maintain manually it seems silly to break the pipeline sync just for on field, so this PR makes it optional, it is encouraged by the .nf-core.yml and existing template.
|
@nf-core-bot fix linting |
adamrtalbot
commented
Jan 13, 2025
|
Did you test this doesn't break things like RO-crate? |
mirpedrol
reviewed
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If authors were missing the pipelines sync failed with a meaningless error. This wastes developer time while users have to fight configuration. Since authors are easy to maintain manually it seems silly to break the pipeline sync just for on field, so this PR makes it optional, it is encouraged by the .nf-core.yml and existing template.
PR checklist
CHANGELOG.mdis updateddocsis updated