Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add badge indicating nf-core template version on main README #3395

Closed
wants to merge 1 commit into from

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Jan 14, 2025

We should add some automation to bump the version number on each template sync (but I'm not clever enough for that)

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Copy link
Contributor

This PR is against the main branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @jfy133,

It looks like this pull-request is has been made against the nf-core/tools main branch.
The main branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to main are only allowed if they come from the nf-core/tools dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@jfy133 jfy133 changed the base branch from main to dev January 14, 2025 09:36
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's nice! But we should also add the logic to update it when running nf-core pipelines sync

@jfy133 jfy133 closed this Jan 14, 2025
@jfy133 jfy133 deleted the version-badges branch January 14, 2025 09:38
@jfy133
Copy link
Member Author

jfy133 commented Jan 14, 2025

Sorry @mirpedrol ! This was a false start PR, right one is here:

#3396

And yes as per the OP I suggested we should have automation but I don't know how to od that unforutnately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants