Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove args stub from module template to satisfy language server #3403

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Remove args stub from module template to satisfy language server #3403

wants to merge 2 commits into from

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Jan 17, 2025 •
edited
Loading

I don't know if there is a linting check for this though...

People can add it back in if needed within the stub

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

mirpedrol
mirpedrol requested changes Jan 17, 2025
View reviewed changes
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait to merge this until v3.2.0, so we don't have bigger changes in a patch release. I am blocking the merge but changes LGTM 🙂

@mirpedrol mirpedrol added this to the 3.2 milestone Jan 17, 2025
@jfy133
Copy link
Member Author

jfy133 commented Jan 17, 2025

Fine with me (although arguably a very small change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirpedrol mirpedrol mirpedrol requested changes

@SPPearce SPPearce SPPearce approved these changes

@mahesh-panchal mahesh-panchal mahesh-panchal approved these changes

@maxulysse maxulysse Awaiting requested review from maxulysse

@sateeshperi sateeshperi Awaiting requested review from sateeshperi

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
5 participants
@jfy133 @mirpedrol @mahesh-panchal @SPPearce @nf-core-bot