Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add accordion to pipeline parameter headers #2044

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add accordion to pipeline parameter headers #2044

wants to merge 4 commits into from
+27 −12

Conversation

sofiahag
Copy link
Member

@sofiahag sofiahag commented Oct 16, 2023 •
edited
Loading

Issue: #1200

I have not gotten the href to the header to work, now sure why it isn't working 🤔

@netlify
Copy link

netlify bot commented Oct 16, 2023 •
edited
Loading

✅ Deploy Preview for nf-core ready!

Name Link
🔨 Latest commit 9fe6ac8
🔍 Latest deploy log https://app.netlify.com/sites/nf-core/deploys/65f6b263d7481e0008909dc9
😎 Deploy Preview https://deploy-preview-2044--nf-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sofiahag sofiahag changed the title add accordion to pipeline parameter headers Add accordion to pipeline parameter headers Oct 16, 2023
@sofiahag sofiahag added WIP Work in progress front-end Website front-end rendering hackathon labels Oct 16, 2023
@sofiahag sofiahag marked this pull request as ready for review October 16, 2023 14:46
@sofiahag sofiahag requested a review from mashehu October 16, 2023 14:46
@sofiahag
Copy link
Member Author

Ah, I know why it isn't working, it's in the SidebarToc.svelte file, line 62

@sofiahag sofiahag removed the WIP Work in progress label Oct 16, 2023
@sofiahag
Copy link
Member Author

Ok, seems to work!

@mashehu mashehu force-pushed the add_accordion_pipelineps branch from 237ac6a to 8c19e90 Compare March 17, 2024 09:02
@mashehu
Copy link
Contributor

mashehu commented Mar 17, 2024

@nf-core-bot fix linting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashehu mashehu Awaiting requested review from mashehu

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
front-end Website front-end rendering hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sofiahag @mashehu @nf-core-bot