Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bytesize admonition #2234

Merged
merged 9 commits into from
Feb 2, 2024
Merged

Bytesize admonition #2234

merged 9 commits into from
Feb 2, 2024

Conversation

ewels
Copy link
Member

@ewels ewels commented Jan 24, 2024

It's bugged me for ages that we have the same Bytesize talk intro in every single bytesize markdown file. Also that you have to manually duplicate the title into a markdown heading.

Updated the website to detect a title that starts with bytesize and then show the standard text as an admonition above the page content. Manually removed all of the duplicated content. There was a lot 😆

Before:

CleanShot 2024-01-24 at 22 42 29@2x

After:

CleanShot 2024-01-24 at 22 42 51@2x

@ewels ewels requested a review from a team as a code owner January 24, 2024 21:43
Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for nf-core ready!

Name Link
🔨 Latest commit 4abe773
🔍 Latest deploy log https://app.netlify.com/sites/nf-core/deploys/65bcfc038a94510008333e4b
😎 Deploy Preview https://deploy-preview-2234--nf-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ewels ewels requested a review from mashehu January 24, 2024 21:43
@ewels
Copy link
Member Author

ewels commented Jan 24, 2024

NB: Many event pages just lost their ToC sidebar as they no longer need headings. May be worth looking into making full width when no headings? Not sure how difficult that'd be. Separate PR anyway.

@mashehu
Copy link
Contributor

mashehu commented Jan 26, 2024

NB: Many event pages just lost their ToC sidebar as they no longer need headings. May be worth looking into making full width when no headings? Not sure how difficult that'd be. Separate PR anyway.

Screenshot 2024-01-26 at 07 48 39

This makes the text too wide. Alternative general approach for event pages: similar to the blog have a left sidebar with other events

Screenshot 2024-01-26 at 07 50 46

@ewels
Copy link
Member Author

ewels commented Jan 26, 2024

have a left sidebar with other events

Like it!

…nition

# Conflicts:
#	src/content/events/2021/bytesize-17-pytest-workflow.md
#	src/content/events/2022/bytesize-nascent.md
#	src/content/events/2022/bytesize_nftest.md
#	src/content/events/2023/bytesize_git_concepts.md
@mashehu mashehu merged commit bcb97fb into nf-core:main Feb 2, 2024
6 checks passed
@ewels ewels deleted the bytesize-admonition branch February 2, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants