-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructuring of concepts under "Physical Entities" top-level concept. #106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this start! It looks great. I only spotted two other part-of relations we should break:
Both
electrochemical equipment
(..7250)electrochemical setup
(..7230)
are collections (part-of). We should just move the siblings one level up (to same level as beaker
) and keep both terms for now.
We could define two new collections to reflect this use case of grouping terms.
@RoteKekse please make an issue if you need separate collections for your use case (in addition to just the concepts).
Hey @dalito my understanding would be that everything from |
Yes, I think you understood this as I meant it. Once Nikos updates the PR it will be easier to see and check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine now!
Changes mostly focusing on generalizing pre-existing photocatalysis concepts (+ fixing some typos).
This PR includes some restructuring of Voc4Cat, regarding the "Physical Entities" top-level concept.
This PR focuses on the “Physical Entities” top-level concept.
Contains changes in "electrochemical setup" and "electrochemical equipment" concept structure.
f6e2adc
to
61f8663
Compare
This PR focuses on the “Physical Entities” top-level concept. I collected concepts that fit under physical entities and restructured them under i) reactor, ii) equipment and iii) material.
You can see a schematic of the new structure and the included concepts under:
https://coggle.it/diagram/Z1LGavQUY3gpFAOY/t/-/42d163500cf6168d1af70503f8c850d913bfe6ff9701f4c29c8291e135cbf71d
I tried to not go too deep, and some concepts are “flat” just below the i) ii) or iii) parent concepts.
I also kept only “Is-A” relations, so I had to delete a few already existing parent-children relations.
I added the following concepts:
First step toward solving #48