Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructuring of concepts under "Physical Entities" top-level concept. #106

Merged
merged 8 commits into from
Dec 16, 2024

Conversation

nmoust
Copy link
Collaborator

@nmoust nmoust commented Dec 9, 2024

This PR focuses on the “Physical Entities” top-level concept. I collected concepts that fit under physical entities and restructured them under i) reactor, ii) equipment and iii) material.

You can see a schematic of the new structure and the included concepts under:
https://coggle.it/diagram/Z1LGavQUY3gpFAOY/t/-/42d163500cf6168d1af70503f8c850d913bfe6ff9701f4c29c8291e135cbf71d

I tried to not go too deep, and some concepts are “flat” just below the i) ii) or iii) parent concepts.
I also kept only “Is-A” relations, so I had to delete a few already existing parent-children relations.
I added the following concepts:

URI Concept Definition
0000187 equipment Apparatus, devices, and instruments employed in the construction and operation of experimental setups and the analysis of catalytic reactions and materials.
0000188 reactor equipment Components being integral parts of a catalytic reactor.
0000189 optical equipment Optical systems involved in light irradiation.
0000190 material Substances used as catalysts, supports, or reactants in catalytic processes.
0000191 detector A device designed to identify a measurable change or signal in a system, often providing a binary (detected / not detected) or a qualitative response.
0000192 sensor A device that measures a specific physical or chemical property and converts it into readable signal, often for continuous monitoring.
0000193 electrochemical reactor A reactor used to perform and study electrochemical reactions.
0000194 catalyst A material that initiates or increases the rate of a catalytic reaction, without it being consumed in the process.

First step toward solving #48

@nmoust nmoust requested a review from dalito December 9, 2024 16:10
Copy link
Member

@dalito dalito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this start! It looks great. I only spotted two other part-of relations we should break:

image

Both

  • electrochemical equipment (..7250)
  • electrochemical setup (..7230)

are collections (part-of). We should just move the siblings one level up (to same level as beaker) and keep both terms for now.
We could define two new collections to reflect this use case of grouping terms.

@RoteKekse please make an issue if you need separate collections for your use case (in addition to just the concepts).

@RoteKekse
Copy link
Contributor

RoteKekse commented Dec 12, 2024

Hey @dalito my understanding would be that everything from beaker, to electrode, to flow cell is electrochemical equipment and that an electro chemical setup is a collection of different equipment and an electrolyte

@dalito
Copy link
Member

dalito commented Dec 12, 2024

Yes, I think you understood this as I meant it. Once Nikos updates the PR it will be easier to see and check.

Copy link
Member

@dalito dalito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine now!

nmoust and others added 8 commits December 16, 2024 15:34
Changes mostly focusing on generalizing pre-existing photocatalysis concepts (+ fixing some typos).
This PR includes some restructuring of Voc4Cat, regarding the "Physical Entities" top-level concept.
This PR focuses on the “Physical Entities” top-level concept.
Contains changes in "electrochemical setup" and "electrochemical equipment" concept structure.
@nmoust nmoust merged commit c9a94b7 into nfdi4cat:main Dec 16, 2024
1 check passed
@nmoust nmoust deleted the Physical-Entities branch December 16, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants