Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always redownload the NGINX GPG signing key in the NGINX OSS Dockerfile #270

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

alessfg
Copy link
Collaborator

@alessfg alessfg commented Jun 20, 2024

Proposed changes

This PR does two things:

  • Modifies the S3 Gateway NGINX OSS Dockerfile to redownload the NGINX GPG signing key in order to avoid issues with expired signing keys.
  • Refactors the Dockerfile into a more sensible structure. Splits the RUN block into a block dedicated to installing NJS (which should remain relatively static) and a block dedicated to update the actual NJS S3 Gateway codebase.

Checklist

Before creating a PR, run through this checklist and mark each as complete:

This PR also refactors the Dockerfile into a more sensible format
@alessfg alessfg self-assigned this Jun 20, 2024
@alessfg alessfg requested a review from 4141done June 20, 2024 19:41
@alessfg alessfg added the bug Something isn't working label Jun 20, 2024
Copy link
Collaborator

@4141done 4141done left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🐳 👍

@alessfg alessfg merged commit 2fcb617 into main Jun 20, 2024
10 checks passed
@alessfg alessfg deleted the redownload-signing-key branch June 20, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants