Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change icons default size #209

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Change icons default size #209

merged 1 commit into from
Dec 12, 2024

Conversation

davidhunter08
Copy link
Collaborator

@davidhunter08 davidhunter08 commented Dec 12, 2024

#198

Changed the icon default sizing to use rem instead of em to stop the icons scaling in size.

The default icon size is still 32px but I don't see that as being a problem as the icons gets used in different component/contexts with the default sizing getting overridden anyway.

NHS service manual icons are set at 34px.

@davidhunter08 davidhunter08 marked this pull request as draft December 12, 2024 10:48
@davidhunter08 davidhunter08 marked this pull request as ready for review December 12, 2024 10:54
@davidhunter08 davidhunter08 linked an issue Dec 12, 2024 that may be closed by this pull request
@davidhunter08 davidhunter08 merged commit eec9aa1 into main Dec 12, 2024
4 checks passed
@davidhunter08 davidhunter08 deleted the icon-size branch December 12, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Default icon size is 32px
2 participants