Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nidcpower metadata #2065

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

jkwoon-NI
Copy link

@jkwoon-NI jkwoon-NI commented Jan 2, 2025

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

Updates metadata for nidcpower to latest 25.0 export.
Resulting changes:

  • Adds INHIBITED to enum OutputStates
  • Changes OuputStates.VOLTAGE and OutputStates.CURRENT enum value names to OuputStates.CONSTANT_VOLTAGE and OutputStates.CONSTANT_CURRENT respectively
  • Updates documentation for measure_buffer_size, measure_complete_event_delay, source_delay, and merged_channels attributes
  • Updates copyright year in the conf.py files in other modules so that the build passes

List issues fixed by this Pull Request below, if any.

None

What testing has been done?

PR checks

@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.34%. Comparing base (1f93c35) to head (f42071f).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2065      +/-   ##
==========================================
- Coverage   92.07%   91.34%   -0.73%     
==========================================
  Files          44       66      +22     
  Lines       13470    16274    +2804     
==========================================
+ Hits        12402    14865    +2463     
- Misses       1068     1409     +341     
Flag Coverage Δ
codegenunittests 84.95% <ø> (?)
nidcpowersystemtests 94.59% <ø> (+<0.01%) ⬆️
nidcpowerunittests 89.53% <ø> (?)
nidigitalsystemtests 92.20% <ø> (-0.04%) ⬇️
nidigitalunittests 68.45% <ø> (?)
nidmmsystemtests 92.72% <ø> (-0.07%) ⬇️
nifakeunittests 87.24% <ø> (?)
nifgensystemtests 94.86% <ø> (-0.05%) ⬇️
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (?)
niscopesystemtests 92.94% <ø> (-0.04%) ⬇️
niscopeunittests 43.20% <ø> (?)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 82.03% <ø> (-0.07%) ⬇️
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
generated/nidcpower/nidcpower/session.py 96.69% <ø> (ø)

... and 32 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f93c35...f42071f. Read the comment docs.

@jkwoon-NI jkwoon-NI marked this pull request as ready for review January 3, 2025 01:44
Copy link
Member

@marcoskirsch marcoskirsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to resolve the code generation bug and possibly the enum mistake.

src/nidcpower/metadata/enums.py Outdated Show resolved Hide resolved
* #### Changed
* **[Source Breaker]:** Enum value names in `OutputStates` have been changed:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added notes about the enum value name changes to the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants