Warning messages for misconfigured log files

nicgalehouse · Jun 25, 2017 · a5a0359 · a5a0359
1 parent e38d8a4
commit a5a0359
Show file tree

Hide file tree

Showing 5 changed files with 44 additions and 7 deletions.
diff --git a/AODamageMeter.UI/AODamageMeter.UI.csproj b/AODamageMeter.UI/AODamageMeter.UI.csproj
@@ -97,6 +97,7 @@
       <Generator>MSBuild:Compile</Generator>
     </Compile>
     <Compile Include="Helpers\DamageMeterExtensions.cs" />
+    <Compile Include="Helpers\FileHelper.cs" />
     <Compile Include="Helpers\SharedTooltips.cs" />
     <Compile Include="RowViewModelDataGrid.cs" />
     <Compile Include="ViewingMode.cs" />

diff --git a/AODamageMeter.UI/Helpers/FileHelper.cs b/AODamageMeter.UI/Helpers/FileHelper.cs
@@ -0,0 +1,10 @@
+using System.IO;
+
+namespace AODamageMeter.UI.Helpers
+{
+    public static class FileHelper
+    {
+        public static void CreateEmptyFile(string filePath)
+            => File.Create(filePath).Dispose();
+    }
+}
diff --git a/AODamageMeter.UI/ViewModels/CharacterInfoViewModel.cs b/AODamageMeter.UI/ViewModels/CharacterInfoViewModel.cs
@@ -1,5 +1,6 @@
 using AODamageMeter.FightEvents.Attack;
 using AODamageMeter.FightEvents.Heal;
+using AODamageMeter.UI.Helpers;
 using System;
 using System.Collections.Generic;
 using System.Diagnostics;
@@ -167,7 +168,7 @@ private void ExecuteAutoConfigureCommand()
                         LogFilePath = $@"{path}\Log.txt";
                         if (!File.Exists(LogFilePath))
                         {
-                            File.Create(LogFilePath);
+                            FileHelper.CreateEmptyFile(LogFilePath);
                             RefreshLogFileSize();
                         }
                         AutoConfigureResult = "Auto-configure succeeded. An existing log file was found.";
@@ -180,7 +181,7 @@ private void ExecuteAutoConfigureCommand()
                         LogFilePath = $@"{path}\Log.txt";
                         if (!File.Exists(LogFilePath))
                         {
-                            File.Create(LogFilePath);
+                            FileHelper.CreateEmptyFile(LogFilePath);
                             RefreshLogFileSize();
                         }
                         AutoConfigureResult = "Auto-configure succeeded. An existing log file was found and reconfigured.";
@@ -197,7 +198,7 @@ private void ExecuteAutoConfigureCommand()
                 Directory.CreateDirectory($@"{chatWindowsPath}\{newWindowName}");
                 File.WriteAllText($@"{chatWindowsPath}\{newWindowName}\Config.xml", GetAutoConfigureConfigXml(newWindowName));
                 LogFilePath = $@"{chatWindowsPath}\{newWindowName}\Log.txt";
-                File.Create(LogFilePath);
+                FileHelper.CreateEmptyFile(LogFilePath);
                 RefreshLogFileSize();
                 bool isAlreadyLoggedIn = Process.GetProcessesByName("AnarchyOnline")
                     .Any(p => p.MainWindowTitle?.Contains(CharacterName) ?? false);

diff --git a/AODamageMeter.UI/ViewModels/DamageMeterViewModel.cs b/AODamageMeter.UI/ViewModels/DamageMeterViewModel.cs
@@ -1,3 +1,4 @@
+using AODamageMeter.UI.Helpers;
 using AODamageMeter.UI.Properties;
 using AODamageMeter.UI.ViewModels.Rows;
 using System;
@@ -85,7 +86,7 @@ public bool TryInitializeDamageMeter(string characterName, string logFilePath)
 
             if (!File.Exists(logFilePath))
             {
-                try { File.Create(logFilePath); }
+                try { FileHelper.CreateEmptyFile(logFilePath); }
                 catch { return false; }
             }
 

diff --git a/AODamageMeter.UI/Views/DamageMeterView.xaml.cs b/AODamageMeter.UI/Views/DamageMeterView.xaml.cs
@@ -1,6 +1,8 @@
-using AODamageMeter.UI.Properties;
+using AODamageMeter.UI.Helpers;
+using AODamageMeter.UI.Properties;
 using AODamageMeter.UI.ViewModels;
 using System.ComponentModel;
+using System.IO;
 using System.Windows;
 using System.Windows.Input;
 
@@ -32,8 +34,30 @@ private void ShowCharacterSelection()
             var characterSelectionView = new CharacterSelectionView(_damageMeterViewModel) { Owner = this };
             if (characterSelectionView.ShowDialog() == true)
             {
-                _damageMeterViewModel.TryInitializeDamageMeter(
-                    Settings.Default.SelectedCharacterName, Settings.Default.SelectedLogFilePath);
+                if (string.IsNullOrWhiteSpace(Settings.Default.SelectedCharacterName))
+                    return; // In this case we said 'No character selected' above the OK button, so I guess they know.
+
+                if (string.IsNullOrWhiteSpace(Settings.Default.SelectedLogFilePath))
+                {
+                    MessageBox.Show(
+                        $"No log file for {Settings.Default.SelectedCharacterName} has been specified.",
+                        "Log file not specified",
+                        MessageBoxButton.OK,
+                        MessageBoxImage.Warning);
+                }
+                else if (!File.Exists(Settings.Default.SelectedLogFilePath))
+                {
+                    MessageBox.Show(
+                        $"Log file for {Settings.Default.SelectedCharacterName} at {Settings.Default.SelectedLogFilePath} can't be found.",
+                        "Log file not found",
+                        MessageBoxButton.OK,
+                        MessageBoxImage.Warning);
+                }
+                else
+                {
+                    _damageMeterViewModel.TryInitializeDamageMeter(
+                        Settings.Default.SelectedCharacterName, Settings.Default.SelectedLogFilePath);
+                }
             }
         }